Tomas Jelinek has posted comments on this change. Change subject: userportal, webadmin: Prevent migration on the frontend ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/21523/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1680: DataCenterWithCluster dataCenterWithCluster = Line 1681: (DataCenterWithCluster) getDataCenterWithClustersList().getSelectedItem(); Line 1682: if (dataCenterWithCluster == null) { Line 1683: return; Line 1684: } > I think that it is more clean to wrap all the rest with well, this is more a question of personal preference. I personally prefer the early return since you do not have that deep nested blocks. Line 1685: Line 1686: VDSGroup cluster = dataCenterWithCluster.getCluster(); Line 1687: Line 1688: Boolean isMigrationSupported = -- To view, visit http://gerrit.ovirt.org/21523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e6f82dd8906fe8aa3d6c9e28eaf0e155feef51c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
