Martin Peřina has posted comments on this change. Change subject: core: Fix audit log messages for auth results ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24729/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 825: AUTH_FAILED_NO_USER_INFORMATION_WAS_FOUND(1182, AuditLogSeverity.ERROR, Line 826: AuditLogTimeInterval.HOUR.getValue()), Line 827: AUTH_FAILED_CLIENT_NOT_FOUND_IN_KERBEROS_DATABASE(1183, AuditLogSeverity.ERROR, Line 828: AuditLogTimeInterval.HOUR.getValue()), Line 829: AUTH_FAILED_INTERNAL_KERBEROS_ERROR(1184, AuditLogSeverity.ERROR, > Martin , all of those will appear once in an hour , do we really want to su I removed time intervals from those that IMO shouldn't be suppressed Line 830: AuditLogTimeInterval.HOUR.getValue()), Line 831: Line 832: // Providers Line 833: PROVIDER_ADDED(1150), -- To view, visit http://gerrit.ovirt.org/24729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa17e2ea206195813b258101a367396399543eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
