Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: new look and feel based on PatternFly ......................................................................
Patch Set 1: (15 comments) http://gerrit.ovirt.org/#/c/24594/1/backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag File backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/stylesheets.tag: Line 2: <%@ tag body-content="empty" %> Line 3: <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> Line 4: <c:if test="${requestScope['brandingStyle'] != null}"> Line 5: <c:forEach items="${requestScope['brandingStyle']}" var="theme"> Line 6: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}${initParam['obrandThemePath']}${theme.path}/common.css"> The other style sheets import the common.css @import url("common.css"); So not sure why you are explicitly importing it here. Line 7: <c:if test="${initParam['obrandApplicationName'] != null && theme.getThemeStyleSheet(initParam['obrandApplicationName']) != null}"> Line 8: <!-- for actual servlets that have to set the request attribute --> Line 9: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}${initParam['obrandThemePath']}${theme.path}/${theme.getThemeStyleSheet(initParam['obrandApplicationName'])}"> Line 10: </c:if> http://gerrit.ovirt.org/#/c/24594/1/backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp File backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp: Line 12: <fmt:param value="${requestScope['locale'].getDisplayLanguage()}" /> Line 13: </fmt:message> Line 14: </title> Line 15: <obrand:stylesheets /> Line 16: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/../userportal/css/patternfly-custom.css" /> Not sure why there is a reference to userportal in here. This should be independent of user portal. Line 17: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/../userportal/css/patternfly-custom-hacks.css" /> Line 18: </head> Line 19: <body onload="pageLoaded()"> Line 20: <div class="obrand_loginPageBackground"> Line 18: </head> Line 19: <body onload="pageLoaded()"> Line 20: <div class="obrand_loginPageBackground"> Line 21: <a href="<obrand:messages key="obrand.common.vendor_url"/>" class="obrand_loginPageLogoImageLink"> Line 22: <img class="obrand_loginPageLogoImage" src="${pageContext.request.contextPath}/../userportal/clear.cache.gif" /> Does this really have to be an image? Can't we just use a div and set a background on it. That way we don't need references to the clear.cache.gif. Line 23: </a> Line 24: <div class="login-pf"> Line 25: <div class="container"> Line 26: <div class="row"> Line 26: <div class="row"> Line 27: Line 28: <div class="col-sm-12"> Line 29: <div id="brand"> Line 30: <img class="obrand_loginFormLogoImage" src="${pageContext.request.contextPath}/../userportal/clear.cache.gif" /> Does this really have to be an image? Can't we just use a div and set a background on it. That way we don't need references to the clear.cache.gif. Line 31: </div> Line 32: </div> Line 33: Line 34: <div class="col-sm-12"> http://gerrit.ovirt.org/#/c/24594/1/backend/manager/modules/welcome/src/main/resources/messages.properties File backend/manager/modules/welcome/src/main/resources/messages.properties: Line 1: #404 error page Line 2: pagenotfound.page_not_found=404 - Page not found Do we really need to bother users with details they don't care about like the HTTP status code? http://gerrit.ovirt.org/#/c/24594/1/backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp File backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp: Line 9: <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> Line 10: <obrand:favicon /> Line 11: <title><fmt:message key="pagenotfound.page_not_found" bundle="${pagenotfound}" /></title> Line 12: <obrand:stylesheets /> Line 13: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom.css" /> Same as before, references to userportal. Line 14: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom-hacks.css" /> Line 15: </head> Line 16: <body> Line 17: <div class="obrand_loginPageBackground"> Line 10: <obrand:favicon /> Line 11: <title><fmt:message key="pagenotfound.page_not_found" bundle="${pagenotfound}" /></title> Line 12: <obrand:stylesheets /> Line 13: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom.css" /> Line 14: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom-hacks.css" /> Same as before, references to userportal. Line 15: </head> Line 16: <body> Line 17: <div class="obrand_loginPageBackground"> Line 18: <a href="<obrand:messages key="obrand.common.vendor_url"/>" class="obrand_loginPageLogoImageLink"> Line 15: </head> Line 16: <body> Line 17: <div class="obrand_loginPageBackground"> Line 18: <a href="<obrand:messages key="obrand.common.vendor_url"/>" class="obrand_loginPageLogoImageLink"> Line 19: <img class="obrand_loginPageLogoImage" src="${pageContext.request.contextPath}/userportal/clear.cache.gif" /> Same as before does this have to be an img? Line 20: </a> Line 21: <div class="login-pf"> Line 22: <div class="container"> Line 23: <div class="row"> Line 23: <div class="row"> Line 24: Line 25: <div class="col-sm-12"> Line 26: <div id="brand"> Line 27: <img class="obrand_loginFormLogoImage" src="${pageContext.request.contextPath}/userportal/clear.cache.gif" /> Same as before does this have to be an img? Line 28: </div> Line 29: </div> Line 30: Line 31: <div class="col-sm-12"> http://gerrit.ovirt.org/#/c/24594/1/backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp File backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp: Line 9: <meta http-equiv="Content-type" content="text/html; charset=utf-8" /> Line 10: <obrand:favicon /> Line 11: <title><fmt:message key="obrand.welcome.title" /></title> Line 12: <obrand:stylesheets /> Line 13: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom.css" /> Same as before, references to userportal. Line 14: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom-hacks.css" /> Line 15: <script src="splash.js" type="text/javascript"></script> Line 16: </head> Line 17: <body onload="pageLoaded()"> Line 10: <obrand:favicon /> Line 11: <title><fmt:message key="obrand.welcome.title" /></title> Line 12: <obrand:stylesheets /> Line 13: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom.css" /> Line 14: <link rel="stylesheet" type="text/css" href="${pageContext.request.contextPath}/userportal/css/patternfly-custom-hacks.css" /> Same as before, references to userportal. Line 15: <script src="splash.js" type="text/javascript"></script> Line 16: </head> Line 17: <body onload="pageLoaded()"> Line 18: <div class="obrand_loginPageBackground"> Line 16: </head> Line 17: <body onload="pageLoaded()"> Line 18: <div class="obrand_loginPageBackground"> Line 19: <a href="<obrand:messages key="obrand.common.vendor_url"/>" class="obrand_loginPageLogoImageLink"> Line 20: <img class="obrand_loginPageLogoImage" src="${pageContext.request.contextPath}/userportal/clear.cache.gif" /> Same as before does this have to be an img? Line 21: </a> Line 22: <div class="login-pf"> Line 23: <div class="container"> Line 24: <div class="row"> Line 24: <div class="row"> Line 25: Line 26: <div class="col-sm-12"> Line 27: <div id="brand"> Line 28: <img class="obrand_loginFormLogoImage" src="${pageContext.request.contextPath}/userportal/clear.cache.gif" /> Same as before does this have to be an img? Line 29: </div> Line 30: </div> Line 31: <noscript> Line 32: <div class="well col-sm-11 well-sm" id="well-error"> http://gerrit.ovirt.org/#/c/24594/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java: Line 109: modelCommandInvoker.invokeDefaultCommand(); Line 110: } Line 111: })); Line 112: Line 113: registerHandler(getView().getLoginForm().addKeyPressHandler(new KeyPressHandler() { @Vojtech, Would doing an @UiHandler make sense here?? Line 114: @Override Line 115: public void onKeyPress(KeyPressEvent event) { Line 116: if (event.getCharCode() == KeyCodes.KEY_ENTER) { Line 117: modelCommandInvoker.invokeDefaultCommand(); http://gerrit.ovirt.org/#/c/24594/1/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.java: Line 25: this.priority = tabData.getPriority(); Line 26: this.tabPanel = tabPanel; Line 27: Line 28: root = new HTMLPanel("li", ""); //$NON-NLS-1$ //$NON-NLS-2$ Line 29: hyperlink = new Anchor(); Can't you use CssResources for the anchor and define the styles in CSS? Line 30: hyperlink.getElement().getStyle().setProperty("fontFamily", "'Open Sans', Helvetica, Arial, sans-serif !important"); //$NON-NLS-1$ //$NON-NLS-2$ Line 31: root.add(hyperlink); Line 32: root.setVisible(true); Line 33: accessible = true; -- To view, visit http://gerrit.ovirt.org/24594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806f2d163d80edb632c4e87524c327066cf3377a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
