Alon Bar-Lev has posted comments on this change. Change subject: db: cleanup: add die and usage ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25215/1/packaging/dbscripts/dbcustomfunctions.sh File packaging/dbscripts/dbcustomfunctions.sh: Line 1: Line 2: die() { Line 3: local m="$1" Line 4: echo "FATAL: ${m}" >&2 Line 5: exit 1 will be removed anyway, but will be fixed. Line 6: } Line 7: Line 8: insert_initial_data() { Line 9: echo "Inserting data..." http://gerrit.ovirt.org/#/c/25215/1/packaging/setup/dbutils/common.sh File packaging/setup/dbutils/common.sh: Line 1: Line 2: die() { Line 3: local m="$1" Line 4: echo "FATAL: ${m}" >&2 Line 5: exit 1 will be removed anyway, but will be fixed. Line 6: } Line 7: Line 8: set_defaults() { Line 9: SERVERNAME="localhost" -- To view, visit http://gerrit.ovirt.org/25215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d708d1855c93f88fcba97c04660b2e4f5f47a6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
