Eli Mesika has posted comments on this change. Change subject: db: cleanup: use single script for schema handling ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25223/2/packaging/dbscripts/schema.sh File packaging/dbscripts/schema.sh: Line 21: -u USER - The username for the database (def. ${DBFUNC_DB_USER}) Line 22: -l LOGFILE - The logfile for capturing output (def. ${DBFUNC_LOGFILE}) Line 23: -m MD5DIR - The directory for generated MD5 files (def. ${DBFUNC_COMMON_MD5DIR}) Line 24: -f VERSION - Enforce version. Line 25: -c COMMAND - Command: apply|refresh|drop I don't think 'drop' is good here , should be 'clean ' instead Line 26: -t - Force cleaning tasks and compensation info. Line 27: Line 28: __EOF__ Line 29: } http://gerrit.ovirt.org/#/c/25223/2/packaging/dbscripts/upgrade.sh File packaging/dbscripts/upgrade.sh: Line 1 Line 2 Please move this comment to a new README file in the dbscripts dir -- To view, visit http://gerrit.ovirt.org/25223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie13ee3d4ddf899f680b592ff58fb9d09573dae59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
