Shahar Havivi has uploaded a new change for review.

Change subject: engine: Set boot order to more then one CDROM if selected
......................................................................

engine: Set boot order to more then one CDROM if selected

When dealing with more then one CDROM we set only the first in list if
user select boot order from CDROM, which can cause a problem if the
first CDROM is payload or cloud-init which are not bootable.
When setting all CDROM to be bootable qemu will try to boot from one
of them.

Change-Id: I7d4783f084623bc59096d87514a6f143e056d5a2
Bug-Url: https://bugzilla.redhat.com/1064927
Signed-off-by: Shahar Havivi <[email protected]>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/25245/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
index f82763e..f3f3956 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
@@ -212,7 +212,6 @@
                 if (device.getIsPlugged()) {
                     device.setBootOrder(++bootOrder);
                 }
-                break; // only one CD is currently supported.
             }
         }
         return bootOrder;


-- 
To view, visit http://gerrit.ovirt.org/25245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d4783f084623bc59096d87514a6f143e056d5a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to