mooli tayer has uploaded a new change for review. Change subject: tools: remove mixed StringBuilder.append and + ......................................................................
tools: remove mixed StringBuilder.append and + Change-Id: I252e1cb04c97e1def77376c0268c6fc1b4d443a2 Signed-off-by: Mooli Tayer <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/25247/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java index ff1ea39..cf93f4e 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java @@ -221,15 +221,15 @@ } catch (MessagingException mex) { StringBuilder errorMsg = new StringBuilder("Failed to send message "); if (from != null) { - errorMsg.append(" from " + from.toString()); + errorMsg.append(" from ").append(from.toString()); } if (StringUtils.isNotBlank(recipient)) { - errorMsg.append(" to " + recipient); + errorMsg.append(" to ").append(recipient); } if (StringUtils.isNotBlank(messageSubject)) { - errorMsg.append(" with subject " + messageSubject); + errorMsg.append(" with subject ").append(messageSubject); } - errorMsg.append(" due to to error: " + mex.getMessage()); + errorMsg.append(" due to to error: ").append(mex.getMessage()); log.error(errorMsg.toString(), mex); throw mex; } -- To view, visit http://gerrit.ovirt.org/25247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I252e1cb04c97e1def77376c0268c6fc1b4d443a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
