Alona Kaplan has posted comments on this change.
Change subject: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event
......................................................................
Patch Set 2:
Consider introducing the same fix to EnterIgnoringFocusHandler.java
Changing-
if (event.getTypeInt() == Event.ONKEYPRESS) {
enterPressed();
}
to ONKEYDOWN.
There is similar bug in chrome and new FF versions (26.0.0) the text area
catches KEYDOWN but doesn't catch KEYPRESS.
In ff older version it catches both of them, so it should be ok to change it to
KEYPRESS.
--
To view, visit http://gerrit.ovirt.org/25236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
