Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: database: extend check empty ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25272/2/packaging/dbscripts/dbfunc-common.sh File packaging/dbscripts/dbfunc-common.sh: Line 54: echo "Creating schema ${DBFUNC_DB_USER}@${DBFUNC_DB_HOST}:${DBFUNC_DB_PORT}/${DBFUNC_DB_DATABASE}" Line 55: if [ "$(dbfunc_psql_statement_parsable " Line 56: select count(*) as count Line 57: from pg_catalog.pg_tables Line 58: where schemaname = 'public' strange there are no tabs there, can you please? also this is specific to our schema so testing for 'schema_version' should remain. Line 59: ")" -eq 0 ]; then Line 60: echo "Creating fresh schema" Line 61: _dbfunc_common_schema_create Line 62: fi -- To view, visit http://gerrit.ovirt.org/25272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
