Federico Simoncelli has posted comments on this change.

Change subject: core: glance import as template should fail on old DCs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility

http://gerrit.ovirt.org/#/c/25286/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java:

Line 203:             }
Line 204: 
Line 205:             setStoragePoolId(getParameters().getStoragePoolId());
Line 206:             // Importing as a template is available only for DC level 
3.4 and above
Line 207:             if 
(getStoragePool().getcompatibility_version().compareTo(Version.v3_4) < 0) {
Apparently there's an infrastructure for this, it's FeatureSupported (iirc)
Line 208:                 return 
failCanDoAction(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL);
Line 209:             }
Line 210:         }
Line 211: 


-- 
To view, visit http://gerrit.ovirt.org/25286
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to