Vojtech Szocs has posted comments on this change. Change subject: webadmin: Consolidate default confirm dialog handling ......................................................................
Patch Set 1: Forgot to mention, there were two reasons I added another constructor in AbstractModelBoundPopupPresenterWidget, as opposed to modifying the existing one: 1) avoid API change (parent class constructor signature) that goes across all dialog presenter widgets 2) @Inject-ing BaseClientGinjector in DefaultConfirmationPopupPresenterWidget caused GWT compile errors due to GIN treating BaseClientGinjector as an ordinary dependency -- To view, visit http://gerrit.ovirt.org/4632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eabc54e661cf68ba62347e0fc2be6972122a18e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
