Omer Frenkel has posted comments on this change. Change subject: core: make migrate commands non-transactive ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24799/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 34: import org.ovirt.engine.core.compat.Guid; Line 35: import org.ovirt.engine.core.utils.NetworkUtils; Line 36: Line 37: @LockIdNameAttribute(isReleaseAtEndOfExecute = false) Line 38: @NonTransactiveCommandAttribute might be an issue if there is a failure on execute, there is no roll back for changes in the db (pending) Line 39: public class MigrateVmCommand<T extends MigrateVmParameters> extends RunVmCommandBase<T> { Line 40: Line 41: /** The ID of the VDS the VM is going to migrate to */ Line 42: private Guid destinationVdsId; -- To view, visit http://gerrit.ovirt.org/24799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894ebd5f062174f9780926a0ce6b499fcc0fc7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
