Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: database: suppress password based on env key ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25347/3/packaging/setup/plugins/ovirt-engine-rename/core/pki.py File packaging/setup/plugins/ovirt-engine-rename/core/pki.py: Line 63: self.environment[ Line 64: otopicons.CoreEnv.LOG_FILTER_KEYS Line 65: ].append( Line 66: osetupcons.PKIEnv.STORE_PASS Line 67: ) Actually, we can merge these to a single list - does it happen that we want to add something to only one of them? Also you duplicated this code in ca.py. Line 68: Line 69: @plugin.event( Line 70: stage=plugin.Stages.STAGE_INIT, Line 71: ) -- To view, visit http://gerrit.ovirt.org/25347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
