Lior Vernia has posted comments on this change. Change subject: webadmin: Manage network dialog- replace VM network checkbox with icon ......................................................................
Patch Set 2: Code-Review+2 (2 comments) Please note comments. http://gerrit.ovirt.org/#/c/24830/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 211: new SafeHtmlWithSafeHtmlTooltipColumn<ClusterNetworkModel>() { Line 212: @Override Line 213: public SafeHtml getValue(ClusterNetworkModel model) { Line 214: return model.isVmNetwork() ? NetworkRoleColumnHelper.getValue(Collections.singletonList(vmImage)) Line 215: : NetworkRoleColumnHelper.getValue((Collections.singletonList(emptyImage))); What I meant was somewhat shorter: return NetworkRoleColumnHelper.getValue(Collections.singletonList(model.isVmNetwork() ? vmImage : emptyImage); Line 216: } Line 217: Line 218: @Override Line 219: public SafeHtml getTooltip(ClusterNetworkModel model) { Line 216: } Line 217: Line 218: @Override Line 219: public SafeHtml getTooltip(ClusterNetworkModel model) { Line 220: return model.isVmNetwork() ? NetworkRoleColumnHelper.getTooltip(Collections.singletonMap(vmImage, This could be made shorter still similarly to above comment. Line 221: constants.vmItemInfo())) Line 222: : NetworkRoleColumnHelper.getTooltip(Collections.<SafeHtml, String> emptyMap()); Line 223: } Line 224: }; -- To view, visit http://gerrit.ovirt.org/24830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie96e3f173b0b510f1b8f20c9e9649eb937054d1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
