Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging
infrastructure
......................................................................
Patch Set 1:
Note to reviewers - in this patch, I'm not using GWTP PreBootstrapper feature,
because of two reasons:
First, GWTP PreBootstrapper feature implementation sucks (i.e. "is not what we
need").
Looking at auto-generated ApplicationControllerImpl (application EntryPoint):
public class ApplicationControllerImpl implements ApplicationController {
@Override
public void init() {
new TestPreBoot().onPreBootstrap();
Scheduler.get().scheduleDeferred(new ScheduledCommand() {
@Override
public void execute() {
DelayedBindRegistry.bind(com.gwtplatform.mvp.client.ClientGinjector.SINGLETON);
com.gwtplatform.mvp.client.ClientGinjector.SINGLETON.getApplicationInit().onBootstrap();
}
});
}
@Override
public void onModuleLoad() {
init();
}
}
As you can see, PreBootstrapper (TestPreBoot) is instantiated (without DI),
onPreBootstrap is called, and usual GWTP bootstrap is performed in deferred
command. Nothing unusual.
The catch is in auto-generated ClientGinjector:
public interface ClientGinjector extends Ginjector, ClientGinjectorExtension {
static ClientGinjector SINGLETON = ((GinjectorProvider)
GWT.create(GinjectorProvider.class)).get();
...
}
So ClientGinjector.
--
To view, visit http://gerrit.ovirt.org/25444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
