David Caro has posted comments on this change. Change subject: Update the build process to determine versioning using git tags ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25404/1/README.maintainer File README.maintainer: Line 55: a tag has to be created on that branch for the above Line 56: automatic to work properly: Line 57: Line 58: X.Y will becomes X.Y.0 Line 59: X.Y.Z becomes X.Y.Z.0 > > Does that mean that a branch can have newer version than master? I always had the idea that master was supposed to be the latest version (meaning master head should be latest than any other branch head). Maybe the spec files do not reflect that, but until now, I haven't seen a branch having a higher version than master on any of our projects (I haven't looked for that neither, except on engine, I have looked engine). So now I'm confused. You want not to use master as latest version? Then you'll have to search all the tags through all the branches to find where to send patches to? Line 60: Line 61: The meaning of this is that the beginning represents Line 62: the version the branch was based on and the last digit Line 63: represents the updates to this specific branch. http://gerrit.ovirt.org/#/c/25404/1/autogen.sh File autogen.sh: Line 22: # - autoconf Line 23: # - automake Line 24: # - gettext-devel Line 25: Line 26: if git status; then > I actually liked seeing the status of the repo here... maybe just the stderr then? Line 27: GITVER=$(git describe --match='[[:digit:]].[[:digit:]]*' --tags | tr -d '\n' | sed 's/-/.0./' | tr - .) Line 28: echo "define([VERSION_NUMBER], [$GITVER])" >build/m4/version.m4 Line 29: else Line 30: GITVER=$(cat VERSION | tr -d '\n') -- To view, visit http://gerrit.ovirt.org/25404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfec13ee13abf05c781d820e865b2d4d54398ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
