Omer Frenkel has posted comments on this change.
Change subject: engine: adding new support for native USB
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 438: if
(vdsGroup.getcompatibility_version().compareTo(Version.v3_1) < 0) {
hard coding supported versions in the code is discouraged, there is
infrastructure using configuration just for this.
please see example of usage of configuration value: HotPlugEnabled and fix
accordingly
--
To view, visit http://gerrit.ovirt.org/4121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25aa315fa85838e4371e232017f7d4eeee558c79
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches