Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Use thread-based workers for GWT 
compilation
......................................................................


webadmin,userportal: Use thread-based workers for GWT compilation

This patch ensures that thread-based permutation worker factory
(ThreadedPermutationWorkerFactory) is used for GWT compilation.

Instead of launching external workers as Java sub-processes
(CompilePermsServer) communicating with main GWT Java compiler
process via socket, this patch makes GWT Java compiler spawn
internal workers as threads. This should reduce overhead when
compiling lots of permutations.

gwt.jjs.maxThreads is set to 4, which means:

  max_worker_threads = min(localWorkers, 4)

where localWorkers is controlled by gwt.compiler.localWorkers

(For details, see ThreadedPermutationWorkerFactory line 84)

In practice, this patch means we can have up to 4 internal
(thread-based) workers active at the same time during GWT
compilation. The actual number of thread-based workers is
controlled via gwt.compiler.localWorkers option.

Change-Id: Iabdbe43ba186d4fde646b01fee3d5196ff35e8ba
Signed-off-by: Vojtech Szocs <[email protected]>
---
M frontend/webadmin/modules/pom.xml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25163
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabdbe43ba186d4fde646b01fee3d5196ff35e8ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to