Yedidyah Bar David has posted comments on this change. Change subject: bin: add the host to a specific cluster ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/25456/10//COMMIT_MSG Commit Message: Line 7: bin: add the host to a specific cluster Line 8: Line 9: Fix bz #1059950 - Ask the user which cluster to use. Default cluster is Line 10: 'Default' if exists. Otherwise, the default is engine_api.clusters.list()[0] Line 11: Please add here: Bug-Url: http://bugzilla.redhat.com/1059950 Line 12: Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 http://gerrit.ovirt.org/#/c/25456/10/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 417: ) Line 418: self.logger.debug('Adding the host to the cluster') Line 419: cluster_l = [c.get_name() for c in engine_api.clusters.list()] Line 420: cluster_name = default_cluster_name if default_cluster_name in \ Line 421: cluster_l else cluster_l[0] OK, now I understand... Perhaps it makes sense to add to the answer file, to allow automation. Can be a different bug/change, though. Line 422: cluster_name = self.dialog.queryString( Line 423: name='cluster_name', Line 424: note=_( Line 425: 'Enter the name of the cluster to which you want to add ' -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
