Allon Mureinik has posted comments on this change. Change subject: core: Intrdoucing UploadStream capabillity ......................................................................
Patch Set 8: Code-Review+1 (1 comment) Minor nit, otherwise looks good. Anyway, I'm waiting for additional eyes to give +2, not for this nit. http://gerrit.ovirt.org/#/c/23460/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UploadStreamVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UploadStreamVDSCommand.java: Line 38: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcUtils; Line 39: Line 40: public class UploadStreamVDSCommand<P extends UploadStreamVDSCommandParameters> extends VdsBrokerCommand<P> { Line 41: Line 42: private static Log log = LogFactory.getLog(UploadStreamVDSCommand.class); should be final Line 43: Line 44: public UploadStreamVDSCommand(P parameters) { Line 45: super(parameters); Line 46: } -- To view, visit http://gerrit.ovirt.org/23460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7af6e7b580e8844c1f0cd661d7f62ece688e31d3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
