Allon Mureinik has posted comments on this change. Change subject: core: add StorageDomainOvfInfo entity/db ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/23461/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOvfInfo.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOvfInfo.java: Line 82: public int hashCode() { Line 83: int result = storageDomainId != null ? storageDomainId.hashCode() : 0; Line 84: result = 31 * result + (ovfDiskId != null ? ovfDiskId.hashCode() : 0); Line 85: result = 31 * result + (updated ? 1 : 0); Line 86: return result; > can you elaborate? what in objectutils? mistake. disregard. Line 87: } Line 88: Line 89: @Override Line 90: public String toString() { http://gerrit.ovirt.org/#/c/23461/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDbFacadeImpl.java: Line 68: } Line 69: Line 70: @Override Line 71: public List<StorageDomainOvfInfo> getAll() { Line 72: throw new NotImplementedException(); > because it's not implemented, no need to implement it as it's never used. I prefer not to leave crippled DAOs. Line 73: } Line 74: Line 75: @Override Line 76: protected MapSqlParameterSource createIdParameterMapper(Guid guid) { -- To view, visit http://gerrit.ovirt.org/23461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cd52f5b9f14559bcec224dee868cf267cd15ebe Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
