Moti Asayag has posted comments on this change.
Change subject: core: [CpuPinning] vdsm broker support
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1144: @DefaultValueAttribute("false")
I think there a unit-test which enforce a type for each configuration value. In
any case - it seems that the auto-merge missed here -
you should add @TypeConverterAttribute(Boolean.class) to CpuPinningEnabled as
well.
--
To view, visit http://gerrit.ovirt.org/4631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia383525ad0f2c314fbe8c65d00a83707bd0ad5aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
