Sandro Bonazzola has posted comments on this change. Change subject: sos: added ovirt_engine_dwh sos plugin ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25518/2/src/sos/plugins/ovirt_engine_dwh.py File src/sos/plugins/ovirt_engine_dwh.py: Line 24: class ovirt_engine_dwh(PluginBase): Line 25: """oVirt Engine DWH related information""" Line 26: Line 27: def setup(self): Line 28: self.addCopySpec('/etc/ovirt-engine-dwh') > I think you should apply the logic of sensitive keys. Yes, I think so. Thanks. Line 29: self.addCopySpec('/var/log/ovirt-engine-dwh') Line 30: Line 31: -- To view, visit http://gerrit.ovirt.org/25518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bd3d5a949c49b2fe918479547390d2c3a2cb62c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Tomáš Došek <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
