Arik Hadas has uploaded a new change for review. Change subject: core: disable command's logging on runningFailed ......................................................................
core: disable command's logging on runningFailed After calling RunVmCommandBase#runningFailed the automatic logging should be disabled since the 'log()' method is called directly by this method. A call to 'setCommandShouldBeLogged(false)' was added inside RunVmCommandBase#runningFailed. It is safe since this method is called on rerun flows, where the automatic logging is not invoked anyway, and from one place as part of the execution phase where the automatic logging is already disabled. Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/25574/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java index 7ff4c2b..9cdc53f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java @@ -246,7 +246,6 @@ } else { - setCommandShouldBeLogged(false); runningFailed(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java index ca89dca..c2243e1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java @@ -129,6 +129,7 @@ try { decreasePendingVms(); Backend.getInstance().getResourceManager().RemoveAsyncRunningCommand(getVmId()); + setCommandShouldBeLogged(false); _isRerun = false; setSucceeded(false); log(); -- To view, visit http://gerrit.ovirt.org/25574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ied9130d2e8dacb94924da220e8ba1a1f1204e681 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
