Shahar Havivi has posted comments on this change. Change subject: UI: Cloud-Init gateway is not mandatory ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25301/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java: Line 14: Line 15: public IpAddressValidation(boolean allowEmpty) { Line 16: String empty = (allowEmpty) ? EMPTY_REGEX : ""; //$NON-NLS-1$ Line 17: setExpression("^" + IP_ADDRESS_REGEX + empty + "$"); //$NON-NLS-1$ $NON-NLS-2$ Line 18: setMessage(ConstantsManager.getInstance().getConstants().thisFieldMustContainIPaddressInFormatMsg()); > yes, but if the user will enter something like: Done Line 19: } -- To view, visit http://gerrit.ovirt.org/25301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b8fb3fd84158ee7c80662e85125b26d22148daa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
