Shahar Havivi has posted comments on this change. Change subject: engine: RFE: set locale language and keyboard via Sysprep ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/25488/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 43 Line 44 Line 45 Line 46 Line 47 > i think we should keep this check Done http://gerrit.ovirt.org/#/c/25488/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java: Line 82: sysPrepContent = replace(sysPrepContent, "$OrgName$", Config.<String> getValue(ConfigValues.OrganizationName)); Line 83: Line 84: if (vm.getVmInit() != null) { Line 85: sysPrepContent = replace(sysPrepContent, "$SetupUiLanguageUiLanguage$", vm.getVmInit().getInputLocale() != null ? Line 86: vm.getVmInit().getInputLocale() : Config.<String> getValue(ConfigValues.DefaultSysprepLocale)); > we need to put default value even if vmInit == null Done Line 87: sysPrepContent = replace(sysPrepContent, "$InputLocale$", vm.getVmInit().getInputLocale() != null ? Line 88: vm.getVmInit().getInputLocale() : Config.<String> getValue(ConfigValues.DefaultSysprepLocale)); Line 89: sysPrepContent = replace(sysPrepContent, "$UiLanguage$", vm.getVmInit().getUiLanguage() != null ? Line 90: vm.getVmInit().getUiLanguage() : Config.<String> getValue(ConfigValues.DefaultSysprepLocale)); -- To view, visit http://gerrit.ovirt.org/25488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I414c1d097a7cf8e23b322ca0f23dcb9d66ac0691 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Juana Garcia <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomáš Došek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
