Moti Asayag has posted comments on this change. Change subject: engine: event should contain the iface which exceeded defined threshold ......................................................................
Patch Set 7: (2 comments) bb http://gerrit.ovirt.org/#/c/25609/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 305: Double receiveRate = iface.getStatistics().getReceiveRate(); Line 306: if ((transmitRate != null && iface.getStatistics().getTransmitRate().intValue() > maxUsedPercentageThreshold) Line 307: || (receiveRate != null && iface.getStatistics().getReceiveRate().intValue() > maxUsedPercentageThreshold)) { Line 308: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); Line 309: logable.setCustomId(iface.getName().toString()); isn't toString() redundant ? I guess the returned type of iface.getName() is string. Line 310: logable.addCustomValue("HostName", _vds.getName()); Line 311: logable.addCustomValue("InterfaceName", iface.getName()); Line 312: logable.addCustomValue("Threshold", maxUsedPercentageThreshold.toString()); Line 313: logable.addCustomValue("TransmitRate", String.valueOf(transmitRate.intValue())); http://gerrit.ovirt.org/#/c/25609/7/packaging/dbscripts/upgrade/03_05_0100_update_vds_netwrok_performance_notifications.sql File packaging/dbscripts/upgrade/03_05_0100_update_vds_netwrok_performance_notifications.sql: Line 1: update event_map set event_up_name = 'HOST_INTERFACE_HIGH_NETWORK_USE' where event_up_name='VDS_HIGH_NETWORK_USE'; I'm not sure that this is sufficient, since the previous event type is remained referenced by its id from the audit-log table. -- To view, visit http://gerrit.ovirt.org/25609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b3510398ac6fa3acf93fcb596dd6ea10b26366 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
