Alon Bar-Lev has posted comments on this change.

Change subject: core: preserve custom db users permissions on...
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/25709/1/packaging/dbscripts/dbfunctions.sh
File packaging/dbscripts/dbfunctions.sh:

Line 322:         # Checks if a view or sp file has been changed
Line 323:         if [[ $? -ne 0 || "${NOMD5}" = "true" ]]; then
Line 324:             echo "upgrade script detected a change in Config, View or 
Stored Procedure..."
Line 325:             echo "Saving custom users permissions on database 
objects..."
Line 326:             permissions=$(get_custom_user_permissions)
quotes
Line 327:             run_pre_upgrade
Line 328:             updated=1
Line 329:         fi
Line 330: 


Line 367:                     # force pre upgrade to run in case no md5 change 
was
Line 368:                     # found but we still upgrade, like in db restore.
Line 369:                     if [ $updated -eq 0 ]; then
Line 370:                        echo "Saving custom users permissions on 
database objects..."
Line 371:                        permissions=$(get_custom_user_permissions)
quotes
Line 372:                        run_pre_upgrade
Line 373:                        updated=1
Line 374:                     fi
Line 375:                     run_required_scripts $file


http://gerrit.ovirt.org/#/c/25709/1/packaging/dbscripts/refreshStoredProcedures.sh
File packaging/dbscripts/refreshStoredProcedures.sh:

Line 40: done
Line 41: 
Line 42: #Dropping all views & sps
Line 43: echo "Saving custom users permissions on database objects..."
Line 44: permissions=$(get_custom_user_permissions)
quotes
Line 45: drop_views
Line 46: drop_sps
Line 47: 
Line 48: #Refreshing  all views & sps


-- 
To view, visit http://gerrit.ovirt.org/25709
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to