Martin Mucha has uploaded a new change for review. Change subject: <webadmin>: do not query twice for same thing. ......................................................................
<webadmin>: do not query twice for same thing. given error message was obtained twice; Even if second run uses hashmap, this is still suboptimal for no reason. Change-Id: I01a09a91f56dbbc0f2577ae0961c872d59149781 Signed-off-by: Martin Mucha <[email protected]> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/25738/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java index 747c6f1..c4fff52 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java @@ -90,8 +90,9 @@ if (!isDynamicVariable(errorMsg)) { errorMsg = errorMsg.replace('.', '_'); } - if (errors.getString(errorMsg) != null) { - ret = errors.getString(errorMsg).replace("\n", "<br/>"); //$NON-NLS-1$ //$NON-NLS-2$ + String errorsString = errors.getString(errorMsg); + if (errorsString != null) { + ret = errorsString.replace("\n", "<br/>"); //$NON-NLS-1$ //$NON-NLS-2$ } else { if ((isDynamicVariable(errorMsg)) || (!changeIfNotFound)) { ret = errorMsg; -- To view, visit http://gerrit.ovirt.org/25738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I01a09a91f56dbbc0f2577ae0961c872d59149781 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
