Shirly Radco has posted comments on this change.

Change subject: reports: edited ic query-storage_domain_type
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/25299/6/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_Storage_Type.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_Storage_Type.xml:

Line 19:             <label>Storage_type</label>
Line 20:             <creationDate>2014-03-04T10:15:31.191+02:00</creationDate>
Line 21:             <updateDate>2014-03-04T10:15:31.191+02:00</updateDate>
Line 22:             <language>sql</language>
Line 23:             <queryString>-- This query will return the storage types 
list in localized session language
> This line is too long please add break to new line
Done
Line 24: -- according to the datacenter that was chosen by the user
Line 25: 
Line 26: SELECT DISTINCT
Line 27:     COALESCE (


Line 26: SELECT DISTINCT
Line 27:     COALESCE (
Line 28:                         enum_translator_localized.value_localized,
Line 29:                         enum_translator_default.value
Line 30:                 )
> spacing is not proper here.
Done
Line 31:     AS value,
Line 32:     enum_translator_default.enum_key,
Line 33:     0 AS sort
Line 34: FROM enum_translator AS enum_translator_default


-- 
To view, visit http://gerrit.ovirt.org/25299
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic79279df2b59592a8ca93517d52b7c7f2ff42e6c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to