Roy Golan has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
......................................................................
Patch Set 1: (3 inline comments)
Sharad this was exactly what we thought. good work.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java
Line 4: activeDirectory("don't know"),
hhh nice - "Microsoft Active Directory"
Line 7: general("what goes here"); // for rootDSE purpose
I think "Deprecated - for auto-detection usages" is ok. any thoughts?
some backgound -
this is an uknown provider type which trriggres auto-detection of the real
provider type. its really temp till we pull the auto-detection out, don't know
which versin will that be.
Line 9: private String vendorName;
great
--
To view, visit http://gerrit.ovirt.org/4727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
