Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Re-work engine ovirt-node host-deploy sequence ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/25685/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java: Line 251: vds.getStoragePoolName()); Line 252: } Line 253: Line 254: @Override Line 255: protected Map<String, Pair<String, String>> getExclusiveLocks() { > Is it ok to have this override of getExclusiveLock at the base of all vds I think you are right, I will move this out of this class. Line 256: return Collections.singletonMap( Line 257: getParameters().getVdsId().toString(), Line 258: LockMessagesMatchUtil.makeLockingPair( Line 259: LockingGroup.VDS, -- To view, visit http://gerrit.ovirt.org/25685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
