Oved Ourfali has posted comments on this change.
Change subject: engine: Add Gluster host
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 161: } else {
Isn't it supposed to happen only for gluster clusters?
Don't see here the test for cluster.supportGlusterService()
Also, don't understand why it is the else here... maybe I'm missing something,
but I would put some comments there, to make it clear.
Line 313:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_GLUSTER_HOST_IS_UP);
Isn't it supposed to be in the if, and not before it?
i.e., add the message only in case no host is up.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 730: ACTION_TYPE_FAILED_NO_GLUSTER_HOST_IS_UP=Cannot ${action} ${type}.
Cannot add gluster host, No gluster host is up.
I'd make it:
Cannot ${action} ${type}. There is no available host in the cluster to probe
the new host.
or something similar.
--
To view, visit http://gerrit.ovirt.org/4736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9a7f36a1b54d0c62297afcdd422938d59ad0997
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
