Liron Ar has posted comments on this change. Change subject: core: change domains status to unknown when there are no reporting hosts ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 86: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcUtils; Line 87: @Logged(errorLevel = LogLevel.ERROR) Line 88: public abstract class IrsBrokerCommand<P extends IrsBaseVDSCommandParameters> extends BrokerCommandBase<P> { Line 89: private static Map<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); Line 90: private static final VDSStatus reportingVdsStatus = VDSStatus.Up; > I'd remove this variable. It doesn't add to readability IMHO. The intention for adding it was to make sure that when one will change it one place he'll consider also the other one rather than forgetting it, not for readabillity..so i prefer to keep it (see lines 100 and 199) Line 91: Line 92: /** Line 93: * process received domain monitoring information from a given vds if necessary (according to it's status). Line 94: * @param vds http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java: Line 12: import org.ovirt.engine.core.compat.Guid; Line 13: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 14: Line 15: Line 16: public class StoragePoolDomainHelper { > Can we try to think of a better domain? that's the original class name, i just moved it to a different package. any suggestions for a better name? Line 17: Line 18: public static final Set<StorageDomainStatus> storageDomainMonitoredStatus; Line 19: Line 20: static { -- To view, visit http://gerrit.ovirt.org/25542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
