Daniel Erez has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 10: (5 comments) http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java: Line 60: if (object.getDiskStorageType() == DiskStorageType.IMAGE) { Line 61: DiskImage diskImage = (DiskImage) object; Line 62: ArrayList<String> quotaNamesArr = diskImage.getQuotaNames(); Line 63: if (quotaNamesArr != null) { Line 64: value = StringHelper.join(", ", quotaNamesArr.toArray());//$NON-NLS-1$ shouldn't it be a single space after the comma? Line 65: } Line 66: } Line 67: return value; Line 68: } http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java: Line 440: StoragePool storagePool = getDataCenters().get(count); Line 441: dataCenterItem.setTitle(storagePool.getName()); Line 442: dataCenterItem.setEntity(storagePool); Line 443: dataCentersItem.addChild(dataCenterItem); Line 444: treeItemById.put(storagePool.getId(), dataCenterItem); most changes in this file can be resolved in a different context and extracted to a separate patch, right? Line 445: Line 446: SystemTreeItemModel storagesItem = new SystemTreeItemModel(); Line 447: storagesItem.setType(SystemTreeItemType.Storages); Line 448: storagesItem.setApplicationMode(ApplicationMode.VirtOnly); http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java: Line 43: Line 44: public interface ViewDef extends AbstractMainTabWithDetailsPresenter.ViewDef<Disk> { Line 45: Line 46: IEventListener getDiskTypeChangedEventListener(); Line 47: void handleQuotaColumnVisibility(); formatter Line 48: Line 49: } Line 50: Line 51: final IEventListener systemTreeListener = new IEventListener() { Line 83: if (!entityChangedEvent.getListeners().contains(getView().getDiskTypeChangedEventListener())) { Line 84: entityChangedEvent.addListener(getView().getDiskTypeChangedEventListener()); Line 85: } Line 86: Line 87: Event systemTreeSelectedItemChangedEvent = instead of using a listener try overriding 'handlePlaceTransition' method to invoke handleQuotaColumnVisibility. Line 88: CommonModel.getInstance().getSystemTree().getSelectedItemChangedEvent(); Line 89: systemTreeSelectedItemChangedEvent.addListener(systemTreeListener); Line 90: Line 91: super.onReveal(); http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java: Line 167: DisksViewColumns.lunProductIdColumn, constants.productIdSanStorage(), luns, Line 168: "100px"); //$NON-NLS-1$ Line 169: Line 170: getTable().ensureColumnPresent( Line 171: DisksViewColumns.qoutaColumn, constants.quotaDisk(), (all || images || luns) && isQuotaVisible, "120px"); //$NON-NLS-1$ I guess it should be visible only for images.. Line 172: Line 173: getTable().ensureColumnPresent( Line 174: DisksViewColumns.descriptionColumn, constants.descriptionDisk(), all || images || luns, Line 175: "90px"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
