Roy Golan has uploaded a new change for review. Change subject: core: removed unused methods from VURTI ......................................................................
core: removed unused methods from VURTI 1. unsed code 2. needless static method Change-Id: I0b028de953d76e25ad73bda76a6727bdc32b1b8e Signed-off-by: Roy Golan <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/26013/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java index b66f4ef..8e91432 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java @@ -945,7 +945,7 @@ private void logDeviceInformation(Guid vmId, Map device) { String message = "Received a {0} Device without an address when processing VM {1} devices, skipping device"; - String deviceType = getDeviceType(device); + String deviceType = (String) device.get(VdsProperties.Device); if (shouldLogDeviceDetails(deviceType)) { Map<String, Object> deviceInfo = device; @@ -1071,16 +1071,6 @@ private static Guid getDeviceId(Map device) { String deviceId = (String) device.get(VdsProperties.DeviceId); return deviceId == null ? null : new Guid(deviceId); - } - - /** - * gets the device type from the structure returned by VDSM - * - * @param device - * @return - */ - private static String getDeviceType(Map device) { - return (String) device.get(VdsProperties.Device); } // if not statistics check if status changed return a list of those @@ -1252,13 +1242,6 @@ && balloonInfo.getBalloonTargetMemory().intValue() != balloonInfo.getBalloonMaxMemory().intValue(); // ballooning was not requested/enabled on this VM } return false; - } - - private Long toMegaByte(Long kilobytes) { - if (kilobytes != null && kilobytes > 0) { - return kilobytes / TO_MEGA_BYTES; - } - return 0L; } protected static boolean isNewWatchdogEvent(VmDynamic vmDynamic, VM vmTo) { -- To view, visit http://gerrit.ovirt.org/26013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b028de953d76e25ad73bda76a6727bdc32b1b8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
