Omer Frenkel has posted comments on this change. Change subject: engine: Numa feature entities ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/23702/10//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-21 20:54:17 +0800 Line 6: Line 7: engine: Numa feature entities Line 8: Line 9: The entities define for NUMA support feature is there any feature page with information about this? design details? Line 10: Line 11: Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Line 12: Bug-Url: https://bugzilla.redhat.com/1069303 http://gerrit.ovirt.org/#/c/23702/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestNumaNode.java: Line 17: private Guid vmGuid; Line 18: Line 19: private Integer index; Line 20: Line 21: private String vcpu_ids; please use java style names (like vcpuIds, vcpuCount..) Line 22: Line 23: private int vcpu_count; Line 24: Line 25: private Long mem_total; http://gerrit.ovirt.org/#/c/23702/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java: Line 7: /** Line 8: * Object which represents host NUMA node information Line 9: * Line 10: */ Line 11: public class NumaNode implements Serializable { what is the difference between this class and the previous one? any relation between them? Line 12: Line 13: private static final long serialVersionUID = -683066053231559224L; Line 14: Line 15: private Guid id; -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
