Roy Golan has posted comments on this change. Change subject: core: Introduce boot time field in VDS ......................................................................
Patch Set 3: Code-Review-1 (1 comment) pls use statistics - its not that important thing for dynamic pls use long instead of Date object http://gerrit.ovirt.org/#/c/25880/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 45: private Integer vm_migrating; Line 46: Line 47: private Integer reserved_mem; Line 48: Line 49: private Date boot_time; pls use long. we don't need a date for that. there is no day light info really . just Net uptime Line 50: Line 51: private Integer guest_overhead; Line 52: Line 53: private String softwareVersion; -- To view, visit http://gerrit.ovirt.org/25880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec679a4ce5ddfbc1735db380feab69eb3798ae6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
