Saggi Mizrahi has posted comments on this change.

Change subject: Fix warning for StorageHelperDirector
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
Line 33:                     java.lang.reflect.Constructor<?> info = 
actionType.getConstructors()[0];
I don't understand what you want. I compiled it before I sent it. It was 
rebased when I first sent it. Because the push in rate is about 10000 
commist\sec I'll not be rebased by the time the compile ends, not to mention 
the fact that my patches can stay unreviewed for a week before someone notices 
them.

Someone with commit rights should rebase, compile and push. It's a very simple 
patch and rebase shouldn't be a problem.

--
To view, visit http://gerrit.ovirt.org/4681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to