Liron Ar has posted comments on this change. Change subject: engine: remove the use of @LockIdNameAttribute ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25944/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LockProperties.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LockProperties.java: Line 3: public class LockProperties { Line 4: Line 5: public static enum Scope { Execution, Manual, None } Line 6: private Scope scope = Scope.None; Line 7: private boolean wait = true; > for the first argument, I do not see that most cases wait is false, and I d Alon, in most cases "wait" is indeed false because the lock is taken upon the synchronized call part from the ui/rest to the backend - the intention was to not have the UI stuck for possibly long time (as many commands issue vdsm calls which are relatively slow and can take up to 3 minutes which is our limitation) - and therefore i assume that the default was set to false. Line 8: Line 9: private LockProperties() {} Line 10: Line 11: public boolean isWait() { -- To view, visit http://gerrit.ovirt.org/25944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57e4f7c00ebcd6a4e9e0e61b7d26f50f2d00858 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
