Alon Bar-Lev has posted comments on this change.
Change subject: engine: remove the use of @LockIdNameAttribute
......................................................................
Patch Set 12:
Hi,
I do not wish to create much noise... however, when we have inheritance I
expect that child is parent with modifications.
This means that child should call parent and modify the result, and not bypass
parent unless there is good reason.
For example:
@Override
protected LockProperties applyLockProperties(LockProperties lockProperties) {
return super.lockProperties.setScope(Scope.Execution);
}
I understand that this is mindset between what we had (annotation), but in the
previous implementation there was no inheritance anyway, so there was no
conflict with expected inheritance behaviour.
--
To view, visit http://gerrit.ovirt.org/25944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie57e4f7c00ebcd6a4e9e0e61b7d26f50f2d00858
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
