Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: support compressed backup/restore ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26073/3/packaging/setup/ovirt_engine_setup/database.py File packaging/setup/ovirt_engine_setup/database.py: Line 650: def backup( Line 651: self, Line 652: dir, Line 653: prefix, Line 654: compr='bzip2', > "user chooses" - you want to ask them? environment? Or "we choose" (but in environment controlled by caller. Line 655: compr_suffix='.bz2', Line 656: ): Line 657: fd, backupFile = tempfile.mkstemp( Line 658: prefix='%s-%s.' % ( Line 701: stdin=dump_proc.stdout, Line 702: stdout=output_file, Line 703: stderr=subprocess.PIPE, Line 704: close_fds=True, Line 705: ) > Maybe it is because otopi blocks SIG_PIPE, locally re-enable it will probab yes, searched, it can be done in preexec_fn function of popen. Line 706: dump_stdout, dump_stderr = dump_proc.communicate() Line 707: compr_stdout, compr_stderr = compr_proc.communicate() Line 708: dump_rc = dump_proc.returncode Line 709: compr_rc = compr_proc.returncode -- To view, visit http://gerrit.ovirt.org/26073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I684f025c9c1d29c701068ba967be5a2115c7a6fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
