Mike Kolesnik has posted comments on this change.
Change subject: core: Add ReloadConfigurationsCommand
......................................................................
Patch Set 6: (2 inline comments)
Basically +2, just some minor comments for your consideration.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
Line 282: log.errorFormat("Not refreshing field {0}: does not
exist in class ConfigValues.", option.getoption_name());
Something minor: You could use ConfigValues.class.getSimpleName() instead of
hard-coded class name.
Line 293: if (values != null) {
I would consider rewriting as:
if (values == null) {
values = new HashMap<String, Object>();
_vdcOptionCache.put(option.getoption_name(), values);
}
values.put(option.getversion(), GetValue(option));
--
To view, visit http://gerrit.ovirt.org/4291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie87110a4e5102372791eb93a4fadecf664b11756
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
