Yaniv Bronhaim has posted comments on this change. Change subject: host-deploy: node-upgrade: apply artificial eof for vdsm-upgrade ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26122/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java: Line 27: public static enum DeployStatus {Complete, Failed, Reboot}; Line 28: Line 29: private static final int BUFFER_SIZE = 10 * 1024; Line 30: private static final int THREAD_JOIN_TIMEOUT = 20 * 1000; Line 31: private static final String ARTIFICIAL_EOF = "component='RHEV_INSTALL'"; can't it be something more related to EOF than component='RHEV_INSTALL'? Line 32: Line 33: private static final Log log = LogFactory.getLog(OVirtNodeUpgrade.class); Line 34: Line 35: private SSHDialog.Control _control; -- To view, visit http://gerrit.ovirt.org/26122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I093357933d2f10c0d90864f53977b832a58dafbd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
