Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Introducing format to id of User and Group API entities
......................................................................


Patch Set 3:

first, as I commented the format yair put is incorrect it should be:

 id=<string>

or:

 providerid=<provider>:<string>

following your example:

we have user XXXX with:

 id=4d42ec8d-7eca-47da-9a54-9f48fc896072
 provider_id=example.com:4d42ec8d-7eca-47da-9a54-9f48fc896072

we can access the same user as (removing the urlencode):

 /users/id=4d42ec8d-7eca-47da-9a54-9f48fc896072
 /users/provider_id=example.com:4d42ec8d-7eca-47da-9a54-9f48fc896072

both will end up with same user record with 
id="id=4d42ec8d-7eca-47da-9a54-9f48fc896072" because the user exists within our 
database.

when accessing via domains, if I understand correctly...

 /domains/f8e3d9f3-e177-465e-913b-6076e8cee885/users

the users that are known to us (defined in users) will result in id="id=xxxx", 
while users that are not known to us will result in 
id="providerid=example.com:yyyyy".

so the following is valid for our user:

  
/domains/f8e3d9f3-e177-465e-913b-6076e8cee885/users/id=4d42ec8d-7eca-47da-9a54-9f48fc896072
  
/domains/f8e3d9f3-e177-465e-913b-6076e8cee885/users/providerid=example.com:4d42ec8d-7eca-47da-9a54-9f48fc896072

and the following is valid for user that is not in our database:

  
/domains/f8e3d9f3-e177-465e-913b-6076e8cee885/users/providerid=example.com:sdfdsfsdDSFDSFsdfds

-- 
To view, visit http://gerrit.ovirt.org/26191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to