Moti Asayag has posted comments on this change. Change subject: core: errors in javadoc, badly placed method. ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/26065/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 853 Line 854 Line 855 Line 856 Line 857 renaming the action to userId and fixing its description will be aligned with the method signature. Line 1438 Line 1439 Line 1440 Line 1441 Line 1442 1. Please add @param taskId 2. Please replace entityType and entityIds with description of @param entitiesMap Line 1470 Line 1471 Line 1472 Line 1473 Line 1474 please add @param taskId Line 2039: /** Line 2040: * Adds a sub step on the current execution context by providing parent and new step information and map that will be resolved to create a text message that describes the new step Line 2041: * @param parentStep parent step to add the new sub step on Line 2042: * @param newStep step to add Line 2043: * @param valuesMap of values that will be used to compose the description of the step please add "a map " at the head of the description Line 2044: */ Line 2045: protected Step addSubStep(StepEnum parentStep, StepEnum newStep, Map<String, String> valuesMap) { Line 2046: return addSubStep(parentStep, newStep, ExecutionMessageDirector.resolveStepMessage(newStep, valuesMap)); Line 2047: } http://gerrit.ovirt.org/#/c/26065/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java: Line 1: package org.ovirt.engine.core.utils.ejb; Line 2: Line 3: /** Line 4: * Enum that defines the beans in engine. All beans must have literals defined in this enum Line 5: * the extra empty comment lines can be removed while at it. Line 6: * Line 7: */ Line 8: public enum BeanType { Line 9: BACKEND, // Backend bean -- To view, visit http://gerrit.ovirt.org/26065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I334d7080989d679fa27082547f1a5950fb530645 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
