Yaniv Dary has posted comments on this change. Change subject: reports: br7b report - added comments to queries ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/25237/3/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data: Line 60: AS is_deleted, Line 61: SUM ( Line 62: CASE Line 63: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 2 Line 64: /* If "Period" equals to "Daily" then "table_name" parameter equals to "hourly" else "daily" */ drop a line here Line 65: THEN Line 66: COALESCE ( Line 67: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 Line 68: ) Line 164: CASE Line 165: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 1 Line 166: THEN Line 167: COALESCE ( Line 168: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 divided to two lines for parameter. Line 169: ) Line 170: ELSE 0 Line 171: END Line 172: ) /60 Line 170: ELSE 0 Line 171: END Line 172: ) /60 Line 173: AS float Line 174: ) ::numeric , 1 ) > 0 drop line and close ROUND like the rest of the functions Line 175: ORDER BY Line 176: CAST ( Line 177: SUM ( Line 178: CASE Line 178: CASE Line 179: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 3 Line 180: THEN Line 181: COALESCE ( Line 182: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 same Line 183: ) Line 184: ELSE 0 Line 185: END Line 186: ) -- To view, visit http://gerrit.ovirt.org/25237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If15e13abe907bcdfb903d02aab049f262d7bf350 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
