Arik Hadas has posted comments on this change. Change subject: core: clone VM from snapshot looses the original template ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26172/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java: Line 206: Line 207: @Override Line 208: protected void updateOriginalTemplate(VmStatic vmStatic) { Line 209: vmStatic.setOriginalTemplateGuid(getParameters().getVmStaticData().getOriginalTemplateGuid()); Line 210: vmStatic.setOriginalTemplateName(getParameters().getVmStaticData().getOriginalTemplateName()); it looks a bit weird to get getParameters().getVmStaticData() again since it is the same as the method argument vmStatic.. in other places, not in ovirt-engine, I would suggest to use the argument instead, but in order to comply with the standards in our commands infrastructure I would suggest to remove the argument (and change AddVmCommand accordingly). anyway, those two solution will be fine by me Line 211: } -- To view, visit http://gerrit.ovirt.org/26172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3daef32ac03b1783b987e682bca6fb5cb9c07b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
