Simone Tiraboschi has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26090/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 95: )) Line 96: return isUp Line 97: Line 98: def _waitEngineUp(self): Line 99: self.logger.debug('Waiting for API to check Engine health status') > Maybe 'Waiting for response from Engine'? Done Line 100: Line 101: tries = self.ENGINE_RETRIES Line 102: isUp = False Line 103: sdk = None Line 123: ], Line 124: insecure=True, Line 125: ) Line 126: isUp = True Line 127: except self._ovirtsdk_api.RequestError: > please debug print the exception, as it may indicate something else Done Line 128: time.sleep(self.ENGINE_DELAY) Line 129: if not isUp: Line 130: raise RuntimeError(_('Engine unreachable')) Line 131: else: Line 127: except self._ovirtsdk_api.RequestError: Line 128: time.sleep(self.ENGINE_DELAY) Line 129: if not isUp: Line 130: raise RuntimeError(_('Engine unreachable')) Line 131: else: > no need else post raise Done Line 132: return sdk Line 133: Line 134: @plugin.event( Line 135: stage=plugin.Stages.STAGE_INIT, -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
