Daniel Erez has uploaded a new change for review. Change subject: core: AuditLogable - replace check to isNullOrEmpty ......................................................................
core: AuditLogable - replace check to isNullOrEmpty AuditLogable - getVmIdRef: replace nullity check with Guid.isNullOrEmpty as mVmId member is pre-set to Guid.Empty. The change is needed for cases when just the VM object is set (rather than the VmId) Change-Id: I894592ecac51674c708c1e9aba8716e4971493cb Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/26319/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java index 0a4f752..4955ac4 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java @@ -200,7 +200,7 @@ } public Guid getVmIdRef() { - if (mVmId == null && getVm() != null) { + if (Guid.isNullOrEmpty(mVmId) && getVm() != null) { mVmId = getVm().getId(); } return mVmId; -- To view, visit http://gerrit.ovirt.org/26319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I894592ecac51674c708c1e9aba8716e4971493cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
